Add react-native-linear-gradient library#10902
Merged
lukewalczak merged 3 commits intogutenberg/after_1.22.0from Feb 6, 2020
Merged
Add react-native-linear-gradient library#10902lukewalczak merged 3 commits intogutenberg/after_1.22.0from
lukewalczak merged 3 commits intogutenberg/after_1.22.0from
Conversation
48cda33 to
6d09331
Compare
|
You can test the changes on this Pull Request by downloading the APK here. |
2cd6f07 to
b388c37
Compare
This was referenced Dec 9, 2019
11a5698 to
a75112c
Compare
Generated by 🚫 dangerJS |
1e18694 to
6ba8172
Compare
Contributor
|
LGTM! Tested with the steps I mentioned in the gutenberg PR. But, since the release branch is cut, we should merge into (Another option is waiting until the release branch is merged into develop again which will happen next Monday) |
d112e32 to
bf21a64
Compare
bf21a64 to
e2604e0
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Ref to gb-mobile: wordpress-mobile/gutenberg-mobile#1616
Ref to gutenberg: WordPress/gutenberg#18823
This PR introduces 1st iteration of mobile
Buttonblock component.To achieve gradient background color on mobile
react-native-linear-gradientcomes in handy.The first iteration includes:
Buttonwith:RichText✅To test:
-> Gradient
Screenshot / gifs:
ANDROID
PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.