Add non-null check for activity in Gutenberg fragment#10860
Merged
malinajirka merged 2 commits intodevelopfrom Nov 28, 2019
Merged
Add non-null check for activity in Gutenberg fragment#10860malinajirka merged 2 commits intodevelopfrom
malinajirka merged 2 commits intodevelopfrom
Conversation
|
You can test the changes on this Pull Request by downloading the APK here. |
malinajirka
reviewed
Nov 27, 2019
|
|
||
| private ArrayList<MediaOption> initOtherMediaImageOptions() { | ||
| ArrayList<MediaOption> otherMediaOptions = new ArrayList<>(); | ||
| FragmentActivity activity = getActivity(); |
Contributor
There was a problem hiding this comment.
AFAIU the surrounded code, the editor will be opened, but the "stock photos" option will be missing. I think we might want to log this into a log (maybe even sentry). Wdyt?
Contributor
Author
There was a problem hiding this comment.
I don't think it will be opened if the activity is null though but I can add tracking in case something else crashes after it passes this check 👍
malinajirka
approved these changes
Nov 27, 2019
Contributor
malinajirka
left a comment
There was a problem hiding this comment.
Thanks @planarvoid! LGTM - feel free to merge it if you decide adding a log isn't worth it/doesn't make sense.
Contributor
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10829
This PR adds a non-null check for activity to the
onGetOtherMediaImageOptionscallback from Gutenberg.To test:
PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.