Do not refresh site details when view not initialized#10855
Merged
Conversation
|
You can test the changes on this Pull Request by downloading the APK here. |
develric
approved these changes
Nov 27, 2019
Contributor
develric
left a comment
There was a problem hiding this comment.
Hi @planarvoid, your analysis seems solid. I also don't know how to test/prove it but the modification seems safe and should make the trick, so 
!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10854
OnSiteChanged is probably called before
onCreateViewis triggered and that causes the views to not be initialized. I've added a check to see if thefragment.getView()is not null before we continue with the event processing. This should fix this crash.To test:
PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.