Do not trigger fragment change when the activity was already closed#10853
Merged
malinajirka merged 3 commits intodevelopfrom Nov 27, 2019
Merged
Do not trigger fragment change when the activity was already closed#10853malinajirka merged 3 commits intodevelopfrom
malinajirka merged 3 commits intodevelopfrom
Conversation
|
You can test the changes on this Pull Request by downloading the APK here. |
malinajirka
approved these changes
Nov 27, 2019
Contributor
malinajirka
left a comment
There was a problem hiding this comment.
Thanks Vojta! ;) As we discussed I'm not a big fan of "commitAllowingStateLoss", but it seems reasonable to use it for this case. 🚢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10852
I've investigated this issue deeply but I couldn't find how it could be happening. It seems that the system gets the bottom nav click after
onSaveInstanceStateis called on the main activity. This shouldn't be possible. I think in this case it's safe to callcommitAllowingStateLossbecause we don't mind we lose the bottom nav position when the activity is being killed. It's better than crashing.To test:
PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.