You can test the changes on this Pull Request by downloading the APK here.

Hey @planarvoid 👋

Do you think you can add a test for the PostDayViewsUseCase for the case when the dayViews list is empty?

Sure, makes sense! I added a test case as requested; since I'm not much familiar with the stats part of the app (as you are instead 😊), I'm not fully sure the Empty state is what we actually expect (that is if I created the correct preconditions for the test) so appreciate your usual valuable feedback! 😎

hey @develric, thanks for the changes. If I understand it correctly, we're fixing here an edge case where the fetch actually returns some data (so the result is not empty) and the get does return an empty list. I have no idea how this happens but I think we can emulate it in the test. The way you wrote it it will never go to the buildUiModel method because fetch is empty and it will just emit State.EMPTY and that's it. I think to get the correct behaviour we need something like this. In this we actually get a SUCCESS result and an empty list. I don't think this is a state we want but it's what we were getting.

val forced = false
        whenever(emptyModel.dayViews).thenReturn(listOf())
        whenever(model.dayViews).thenReturn(listOf(Day("2019-10-10", 50)))
        whenever(store.getPostDetail(site, postId)).thenReturn(emptyModel)
        whenever(store.fetchPostDetail(site, postId, forced)).thenReturn(
                OnStatsFetched(
                        model
                )
        )

        val result = loadData(true, forced)

        Assertions.assertThat(result.state).isEqualTo(SUCCESS)
        Assertions.assertThat(result.data).isEmpty()

Thanks for the clarifying explanation @planarvoid 🙇‍♂️! I have reported changes here with an extra comment to get the context. Let me know 😊.

thanks for the change @develric ! The comment makes a lot of sense 👍