Fix null site model in PostListActivity#10826
Merged
malinajirka merged 4 commits intodevelopfrom Nov 27, 2019
Merged
Conversation
|
You can test the changes on this Pull Request by downloading the APK here. |
malinajirka
requested changes
Nov 25, 2019
Contributor
malinajirka
left a comment
There was a problem hiding this comment.
Thanks @planarvoid! I think I found one bug, but it looks good otherwise.
| ActivityLauncher.viewCurrentBlogPages(requireActivity(), getSelectedSite()); | ||
| SiteModel selectedSite = getSelectedSite(); | ||
| if (selectedSite != null) { | ||
| ToastUtils.showToast(getActivity(), R.string.site_cannot_be_loaded); |
Contributor
There was a problem hiding this comment.
Shouldn't this line be in an else clause? Wdyt?
Contributor
Author
|
@malinajirka thanks for the check! I've fixed what you found and it should be ready for another check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8363
We're still passing nullable
SiteModelto the intent when creating activities. This PR should fix that when creating thePostListActivity. All the places should now be checked for non-nullSiteModel. I don't know which solution is the best.viewCurrentBlogPageshad alreadyNonNullparameter but we were still passing a nullable SiteModel. That's why is my solution different than the one withviewCurrentBlogPosts.To test:
PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.