Download external media on Share intent received#10824
Conversation
|
You can test the changes on this Pull Request by downloading the APK here. |
malinajirka
left a comment
There was a problem hiding this comment.
Thanks @planarvoid! LGTM - the only thing we might want to consider is adding a comment that MediaUtils.downloadExternalMedia must be called on the UI thread (see CopyMediaToAppStorageUseCase). Wdyt?
|
Btw I also noticed, that when you share a media and you are not logged in, the sign up flow is shown -> I believe that this scenario is not covered. However, it seems like a low priority issue. |
|
@malinajirka thanks for the check. I've added the comment to the
I think this is unrelated to this issue and is indeed low priority |
Fixes #10575
This crash is probably triggered because the
contentsystem URIs are only available for a short time period after they are shared with our app. When the user has multiple sites we show a site selector first before we pass the URIs to theMediaBrowserActivitywhich downloads them. This PR changes this behaviour and saves the files directly when they are shared with the app. This should fix the crash.I've also found out there is a crash when you try to share a video with the app (tried on an emulator with the latest android). I think it's related to react-native-image-picker/react-native-image-picker#1139
To test:
To test 2:
To test 3:
PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.