Make number suffixes translatable through an injected class#10818
Merged
malinajirka merged 6 commits intodevelopfrom Nov 27, 2019
Merged
Make number suffixes translatable through an injected class#10818malinajirka merged 6 commits intodevelopfrom
malinajirka merged 6 commits intodevelopfrom
Conversation
Generated by 🚫 dangerJS |
|
You can test the changes on this Pull Request by downloading the APK here. |
malinajirka
reviewed
Nov 22, 2019
Contributor
malinajirka
left a comment
There was a problem hiding this comment.
Thanks @planarvoid, nice improvement! ;)
I've found one possible bug, but it looks good otherwise.
| icon = icon, | ||
| iconUrl = if (icon == null) group.icon else null, | ||
| text = group.name, | ||
| value = group.total?.toFormattedString(), |
Contributor
There was a problem hiding this comment.
It seems this would be evaluated to "null" before the change, but is evaluated to "0" now. Is this change intentional? Wdyt?
Contributor
Author
There was a problem hiding this comment.
Good catch! This was happening in multiple places so I fixed it in 9a6d791
We now have 3 methods (for all number formats):
- One with nullable parameter and no default value -> returns nullable result
- One with nullable parameter and mandatory default value -> returns non-null result
- One with non-null parameter -> returns non-null result
I've added tests for all the new methods in 0c12f68 and f9ffab0
Contributor
Author
|
@malinajirka thanks for the check! I've fixed the issue and added tests. Let me know if the solution is sufficient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10753
This PR removes the
toFormattedStringextension function and replaces it with a call on an injectedStatsUtilsobject. The extension function doesn't make sense since we have to use other injected fields to build the formatted string (resource provider and locale manager).To test:
PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.