Prevent contributors from uploading media files#10812
Merged
planarvoid merged 2 commits intodevelopfrom Nov 28, 2019
Merged
Conversation
|
You can test the changes on this Pull Request by downloading the APK here. |
# Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/photopicker/PhotoPickerFragment.java # WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java
planarvoid
approved these changes
Nov 28, 2019
Contributor
planarvoid
left a comment
There was a problem hiding this comment.
thanks! It works well 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10666
I recommend using another diff tool than GitHub - eg. the changes in Android Studio diff are more obvious.
The goal of this PR is to prevent users who don't have permission, to upload media files from the Editor (eg. Contributors). Ideal solution wouldn't even show the items on the UI (eg. we wouldn't show "Capture image" as we know, it'll require media upload). I decided to implement this temporary solution and we can consider reverting it when we add support for filtering media options before Gutenberg shows them on the UI. We could use similar technique to this for all options we show on the UI. Wdyt?
To test:
=> the only option which should work is WPMedia library as the media files are already present on the server
PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.