Show stock photos only for wpcom or jetpack sites#10743
Closed
Show stock photos only for wpcom or jetpack sites#10743
Conversation
1 task
wpmobilebot
reviewed
Nov 6, 2019
| String wpcomLocaleSlug = languageString.replace("_", "-").toLowerCase(Locale.ENGLISH); | ||
| return GutenbergEditorFragment.newInstance("", "", mIsNewPost, wpcomLocaleSlug); | ||
| boolean supportsStockPhotos = mSite.isUsingWpComRestApi(); | ||
| return GutenbergEditorFragment.newInstance("", "", mIsNewPost, wpcomLocaleSlug, supportsStockPhotos); |
Contributor
There was a problem hiding this comment.
Reporter: Checkstyle
Rule: com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck
Severity: ERROR
File: /home/circleci/project/WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java L2162
Line is longer than 120 characters (found 125).
|
You can test the changes on this Pull Request by downloading the APK here. |
Contributor
Author
|
Closing in favor of: #10745 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # wordpress-mobile/gutenberg-mobile#1539 (comment)
We should not show the Free Media Library option on Self Hosted site, since this is a WPCom/Jetpack-only feature.
To test:
Test 1:
https://jurassic.ninja
Choose from Free Photo Libraryshouldn't be visibleTest 2:
Choose from Free Photo Libraryshould be visiblePR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.