Conversation
Add support to present giphy and pexel image
|
You can test the changes on this Pull Request by downloading the APK here. |
…ilable-from-image-block # Conflicts: # libs/gutenberg-mobile
| for (Map.Entry<String, MediaFile> mediaEntry : mediaList.entrySet()) { | ||
| rnMediaList.add( | ||
| new Media( | ||
| isNetworkUrl ? Integer.valueOf(mediaEntry.getValue().getMediaId()) : mediaEntry.getValue().getId(), |
There was a problem hiding this comment.
Reporter: Checkstyle
Rule: com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck
Severity: ERROR
File: /home/circleci/project/libs/editor/WordPressEditor/src/main/java/org/wordpress/android/editor/GutenbergEditorFragment.java L763
Line is longer than 120 characters (found 127).
…ilable-from-image-block # Conflicts: # libs/gutenberg-mobile
…ilable-from-image-block
|
Noticed a crash on rotation, already existing in previous app versions too but still happening here too: #10700 I feel that will probably need some work to fix so, let's not block this PR on it. |
| ArrayList<MediaOption> otherMediaOptions = new ArrayList<>(); | ||
|
|
||
| String packageName = getActivity().getApplication().getPackageName(); | ||
| int stockMediaResourceId = getResources().getIdentifier("photo_picker_stock_media", "string", packageName); |
There was a problem hiding this comment.
Something I noticed while product reviewing the PR is that this string can get pretty long in other languages (tested in french) and in that case will be cropped in the selection menu. Not a blocker but we'll probably want to address that in gutenberg (I'm thinking long pressing to make the text scroll for instance).
|
Good catch on the translations, @Tug! There is probably a larger discussion to be had here regarding what we do in terms of truncation, but I think it's related to an existing proposal I made a while back to add a title/description to this sheet. Specifically for this issue, what that would mean is adding a section header that is relevant to all items and then shorten the options as a result. That would look like this (Android left, iOS right):
Would that make more sense? I've been hoping to add a section header on this sheet for a while, so this might solve that concern as well. This seems clearer and also more scalable for translations. // @marecar3 |
…ilable-from-image-block
cameronvoell
left a comment
There was a problem hiding this comment.
Tested latest, Android updates look good to me!
Fixes wordpress-mobile/gutenberg-mobile#720
To test:
Follow instructions on gb-mobile PR: wordpress-mobile/gutenberg-mobile#1469
PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.