Respect allowMultipleSelection flag for media-text block#10597
Merged
mkevins merged 3 commits intotry/fix-media-text-device-pickerfrom Oct 14, 2019
Merged
Conversation
This was referenced Oct 11, 2019
|
You can test the changes on this Pull Request by downloading the APK here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#1403
Description
This PR adds a
GUTENBERG_SINGLE_MEDIA_PICKERMediaBrowserType, which is used to respect theallowMultipleSelectionflag within theMediaBrowserActivity.To test:
Follow steps listed here: WordPress/gutenberg#17537 (comment)
and make sure videos and images can be selected from the picker after choosing "Choose from device".
Also, it should be possible to select videos and images after selecting "WordPress Media Library".
When selecting via "WordPress Media Library", only a single item should be selectable. When tapping a video or image, the item should be inserted into the media-text block (without allowing multiple items to be selected).
Screencasts
PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.