feat: support multiple prop in gutenberg editor#10475
Merged
pinarol merged 17 commits intowordpress-mobile:developfrom Oct 2, 2019
Merged
feat: support multiple prop in gutenberg editor#10475pinarol merged 17 commits intowordpress-mobile:developfrom
pinarol merged 17 commits intowordpress-mobile:developfrom
Conversation
Contributor
|
Is this PR ready for review? If so, could you please add some description? @dratwas |
Contributor
Contributor
Author
|
Hi all :) This PR is ready to review. |
mkevins
reviewed
Oct 2, 2019
WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java
Outdated
Show resolved
Hide resolved
Generated by 🚫 dangerJS |
|
You can test the changes on this Pull Request by downloading the APK here. |
mkevins
approved these changes
Oct 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I added the possibility to set multiple media when inserting to the block.
Related gutenberg-mobile PR wordpress-mobile/gutenberg-mobile#1331
CI is failing when creating PRs from fork so there is PR that is created based on this one - #10556
To test:
At this moment we don't support gallery block so this change can not be tested without changes in gutenberg-mobile JS bundle. In the future, we will use this functionality to multiple selections of media for the gallery.