Issue/10189 Clears old data from previous visits to wizard steps#10198
Conversation
… previous visits is cleared for that step.
|
Just want to mention, I cleared segmentId on the segment step and domain on the domain step even though it is currently impossible to reproduce the issue on those steps. I coded defensively here in case restrictions on requiring those fields are lifted in the future. Let me know if that was overzealous and it is preferred that we only clear title, tagline, and verticalId for now. |
|
looking at failed tests now |
…o that we do not go straight back to segment step and clear our state
…e is not null, in order to limit unnecessary updates to the state and to simplify testing while retaining default data class equality
…l because of cleared state
|
Ready for review (can't change labels :-P, but I can comment!) |
|
Thank you, @cameronvoell! @malinajirka it looks like you are the most knowledgeable on Site Creation. Would you be able to review this? 🙂 |
|
Thanks @cameronvoell ! It looks and works great - good job. I've left two nitpicking comments! |
WordPress/src/main/java/org/wordpress/android/ui/sitecreation/SiteCreationMainVM.kt
Show resolved
Hide resolved
WordPress/src/test/java/org/wordpress/android/ui/sitecreation/SiteCreationMainVMTest.kt
Outdated
Show resolved
Hide resolved
|
Did a git rebase for the better commit ordering, but forgot it would make the PR so hard to read. Force pushed to fix it :-P |
28b3d39 to
1c8d8e7
Compare
malinajirka
left a comment
There was a problem hiding this comment.
LGTM 🚢 ! Thank you ;)
Fixes #10189
To test:
Steps to reproduce the behavior
*Note if you can not create sites in test build like me, you may need to verify through the debugger (and through the lack of old title searches appearing like they were before the fix)
Update release notes:
RELEASE-NOTES.txt.