Issue/10087 domain suggestions on clear#10181
Merged
malinajirka merged 4 commits intowordpress-mobile:developfrom Jul 10, 2019
Merged
Issue/10087 domain suggestions on clear#10181malinajirka merged 4 commits intowordpress-mobile:developfrom
malinajirka merged 4 commits intowordpress-mobile:developfrom
Conversation
Contributor
Author
|
Just want to comment on this PR that while testing to fix this issue I found another minor issue in the site creation flow. #10189 That issue is unrelated to this issue or PR. |
malinajirka
approved these changes
Jul 10, 2019
Contributor
malinajirka
left a comment
There was a problem hiding this comment.
Thank you so much for the contribution! ;) Everything looks and works as expected 🚢
SideNote: #10189 -> great find!! Thanks for submitting the new issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10087
This PR adds default suggestions to the site creation domain search after clear. I also included two new tests that test clear behavior when a title is or is not set.
Before Fix:
To test:
After Fix:
Update release notes:
RELEASE-NOTES.txt.