Skip to content

Lint Warnings - Resolve AppBundleLocaleChanges #18188

@ParaskP7

Description

@ParaskP7

As part of the #18161 task, this AppBundleLocaleChanges got suppressed and moved closer to source (instead of it being within the baseline.xml file).

This was done in order to make the suppression more robust as although is seems to be working locally, it actually failing when running on CI.

However, this warning should be fixed instead and that's what this issue is about, to try and resolve this warnings instead of suppressing it (expand to see details).

Issue Details (Example)
    <issue
        id="AppBundleLocaleChanges"
        message="Found dynamic locale changes, but did not find corresponding Play Core library calls for downloading languages and splitting by language is not disabled in the `bundle` configuration"
        errorLine1="        defaultLocaleConfiguration.setLocale(defaultLocale);"
        errorLine2="        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="../libs/editor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergUtils.java"
            line="43"
            column="9"/>
    </issue>

Message: Found dynamic locale changes, but did not find corresponding Play Core library calls for downloading languages and splitting by language is not disabled in the 'bundle' configuration

PS: The above is just an example, same applies to the below:

  • GutenbergUtils.getTranslations(...)
  • ComposeUtils.LocaleAwareComposable(...)
  • LocaleManager.updatedConfigLocale(...)
  • LocaleManager.updateResources(...)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions