This repository was archived by the owner on Jun 23, 2022. It is now read-only.
Adds values for Account Settings & My Profile#2
Closed
Conversation
Contributor
Author
|
I've noticed that it's kind of different to add events to Android. The issues in the original PR should be fixed, but I am still not sure about these changes at all. This is the first time I am adding any events to Android, so please let me know if I messed up anything. Please note that I've changed the |
Contributor
|
Hey @oguzkocer - Could you please checkout wp-android/develop, add the changes available in this PR in a new branch there, and then create a new PR in wp-android project? I can do this for you if you're busy. |
Contributor
Author
|
Thanks @daniloercoli. I've opened the PR in the WordPress-Android project. |
Contributor
|
Addressed in wordpress-mobile/WordPress-Android#3488 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like
OPENED_SETTINGSvalue is not yet used. To make it clear, I've renamed it toOPENED_SITE_SETTINGSwhich we should start using and addedOPENED_MY_PROFILE&OPENED_ACCOUNT_SETTINGS. These changes are made in consistence with the iOS Repo. Here is the PR for that change./cc @daniloercoli & @astralbodies