This repository was archived by the owner on Jun 19, 2025. It is now read-only.
Make sure orientation is correctly set when saving images to the camera roll#338
Merged
SergioEstevao merged 1 commit intodevelopfrom Oct 17, 2019
Merged
Conversation
etoledom
approved these changes
Oct 17, 2019
Contributor
etoledom
left a comment
There was a problem hiding this comment.
Looks and works great 🎉
Thank you @SergioEstevao 🙏
1 task
Contributor
|
Tested with an iPhone 6s running iOS 11.41 and an iPad Mini running iOS 12.0.1. The photo orientation was always as expected. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #337
This PR makes sure that images added to the camera roll have the correct orientation set
To test: