Fix: indent and undent using tab and shift+tab by etoledom · Pull Request #1174 · wordpress-mobile/AztecEditor-iOS

etoledom · 2019-04-18T08:56:43Z

This PR fixes indent and undent view Tab / Shift+Tab keys.

Note: So far the unit tests were created, but not fix have been added yet.

Explanation of the issue:

From this initial HTML:

<ul>
    <li>Hello</li>
    <li>world</li>
</ul>

Pressing Tab in the last list item we should get this:

<ul>
    <li>Hello
        <ul>
            <li>world</li>
        </ul>
    </li>
</ul>

But we get this:

<ul>
    <li>Hello</li>
    <li>
        <ul>
            <li>world</li>
        </ul>
    </li>
</ul>

Starting from this HTML:

<ul>
    <li>Hello
        <ul>
            <li>world</li>
        </ul>
    </li>
</ul>

Pressing Shift + Tab in the indented list item we should get the original:

<ul>
    <li>Hello</li>
    <li>world</li>
</ul>

But we get:

<ul>
  <li>Hello </li>
world
</ul>

Adding unit tests covering indent and undent using tab and shift+tab

aa37d1d

etoledom added the [Status] Not Ready For Review label Apr 18, 2019

etoledom self-assigned this Apr 18, 2019

etoledom mentioned this pull request Apr 18, 2019

List Block fixes for iOS. wordpress-mobile/gutenberg-mobile#863

Closed

etoledom closed this Dec 8, 2020

etoledom deleted the issue/indent-unident-with-tab-shift-tab branch December 8, 2020 16:45