Skip to content

Add test to check nested list output.#1165

Merged
etoledom merged 4 commits intodevelopfrom
issue/1164_list_indents_split
Apr 17, 2019
Merged

Add test to check nested list output.#1165
etoledom merged 4 commits intodevelopfrom
issue/1164_list_indents_split

Conversation

@SergioEstevao
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao commented Apr 1, 2019

Fixes #1164

At the moment this only adds a unit test to verify the bug

To test:

  • Open the demo empty app
  • Copy paste the following HTML:
<ul>
  <li>List 1</li>
  <li>List 2
           <ul>
              <li>List 3</li>
              <li>List 4</li>
            </ul>
  </li>
</ul>
  • Switch to visual and back to HTML and see if the output is correct.

@SergioEstevao SergioEstevao added this to the Next Stable milestone Apr 1, 2019
@SergioEstevao SergioEstevao self-assigned this Apr 1, 2019
SergioEstevao and others added 2 commits April 5, 2019 17:33
@etoledom etoledom self-assigned this Apr 12, 2019
@etoledom
Copy link
Copy Markdown
Contributor

etoledom commented Apr 12, 2019

Adding commit that fixes nested lists parsing.
The problem was with the <li> merging logic. We want to merge list items when its child is a new list.
Added an exception for this together with the exception for <figure>.

I also added the possibility to a new bullet style for nested unordered lists, so it looks the same as on Gutenberg Web.
Since Android doesn't have support for this yet, we won't change the indented bullet character yet, but it's ready to be changed anytime 👍

To test:

@diegoreymendez if you could take a look would be great!

diegoreymendez
diegoreymendez reviewed Apr 16, 2019
View reviewed changes
@etoledom etoledom force-pushed the issue/1164_list_indents_split branch from f11e3d7 to 4f989ae Compare April 17, 2019 06:06
@etoledom
Copy link
Copy Markdown
Contributor

etoledom commented Apr 17, 2019

@diegoreymendez - Thanks for the review!

I removed the commits that added the bullets improvement and moved them here: #1173 . Added @SergioEstevao as reviewer since it's not a priority, but feel free to review that one too if you have the time/curiosity 👍

@etoledom etoledom mentioned this pull request Apr 17, 2019
Closed
@etoledom etoledom requested a review from diegoreymendez April 17, 2019 15:52
diegoreymendez
diegoreymendez approved these changes Apr 17, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice change!

@etoledom etoledom merged commit d130f05 into develop Apr 17, 2019
@etoledom
Copy link
Copy Markdown
Contributor

etoledom commented Apr 17, 2019

Thank you! 🙏

@etoledom etoledom deleted the issue/1164_list_indents_split branch April 17, 2019 16:41
@jtreanor jtreanor mentioned this pull request Apr 19, 2019
Merged
@SergioEstevao SergioEstevao modified the milestones: Next Stable, 1.6.3 Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@etoledom etoledom etoledom left review comments

@diegoreymendez diegoreymendez diegoreymendez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@SergioEstevao SergioEstevao

@etoledom etoledom

Labels

[Type] Bug

Projects

None yet

Milestone

1.6.3

Development

Successfully merging this pull request may close these issues.

Nested Lists are being break in several items

3 participants

@SergioEstevao @etoledom @diegoreymendez