Conversation
mkevins
approved these changes
Dec 10, 2019
Contributor
mkevins
left a comment
There was a problem hiding this comment.
Tested this on WordPress-Android by setting aztecVersion=4416b4f041628260bb9aab4e88ce82d20d27cb1a and testing various text input flows in both the Gutenberg editor and Aztec. Everything works as expected. LGTM after conflicts are resolved.
Contributor
Author
|
Checked a few paths after merge conflict resolution, seems to work well and tests passed, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #834
According to what has been observed (no significant contribution to lowering the number of occurrences of the crash observed in wordpress-mobile/WordPress-Android#9904), the patch is being reverted to avoid introducing this unneeded complexity.