Conversation
Contributor
|
Updated the PR, expanded it to make 👋 @daniloercoli , you think you can make a review pass on this one? Thanks! |
Contributor
|
Nice! With tests updated this PR can be 🚢ed! Feel free to merge once the conflicts are resolved. |
Contributor
|
Thanks for the review @daniloercoli ! Let's hold off merging this until the parent PR is also ready to merge wordpress-mobile/gutenberg-mobile#275. This way we can avoid a potential revert in case the parent PR doesn't get merged. |
Contributor
|
We're giving the "go ahead with merging" for the Gutenberg and gutenberg-mobile side PRs so, merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Gutenberg has
<em>defined as the tag for italic formatting. Aztec can handle<em>but converts it to<i>when sending back the html to gutenberg-mobile. This causes inconsistencies in the UI and should be addressed.Test
gutenberg-mobilePR Use format-library for the formatting bar gutenberg-mobile#275gutenberg-mobile:formatting
Review
@hypest