Conversation
|
When I start the demo app the caption is right aligned even though there is no |
| nestable: IAztecSpan, parents: ArrayList<IAztecNestable>?, nestingLevel: Int) { | ||
| nestable: IAztecParagraphStyle, parents: ArrayList<IAztecNestable>?, nestingLevel: Int) { | ||
|
|
||
| CssStyleFormatter.removeStyleAttribute(nestable.attributes, CssStyleFormatter.CSS_TEXT_ALIGN_ATTRIBUTE) |
There was a problem hiding this comment.
It's not clear to me why we're removing the text-align style attribute, and then re-applying it in case nestable.shouldParseAlignmentToHtml() is true.
There was a problem hiding this comment.
Hmm, I'm trying to think of a case when this could be a problem. It's not an issue for captions because the plugin removes the style attribute. But I suppose we can move it within the if statement.
|
|
||
| val spans = editableText.getSpans(start, end + endModifier, spanType) | ||
| spans.forEach { span -> | ||
| spans.forEach innerForEach@ { span -> |
There was a problem hiding this comment.
Niptick - Is innerForEach@ needed here?
There was a problem hiding this comment.
Thanks, it's a leftover from a change that required it but eventually got removed.
|
About the caption alignment - it's here :). |
|
Impressive. |
Addresses #465.
All inline and block elements can now by aligned to the left, right and center. If alignment is applied to plain text it is surrounded by
<p>tags. Multi-selection is also supported.The alignment formatting is parsed to HTML as a CSS style.
The toolbar button functionality is overloaded for the
[caption]shortcode, where it's used for caption-specific alignment parsing (e.g.align="alignright").Don't be put off by the large number of changes as a lot of them are just resource files and unit tests.
Note that the cursor position is behaving a little weird around empty hidden spans, because special zero-width characters are used for the spans.