Skip to content

Android 13 update target sdk to 33#1040

Merged
ravishanker merged 7 commits intotrunkfrom
Android-13-Update-targetSdk-to-33
Mar 29, 2023
Merged

Android 13 update target sdk to 33#1040
ravishanker merged 7 commits intotrunkfrom
Android-13-Update-targetSdk-to-33

Conversation

@ravishanker
Copy link
Copy Markdown
Contributor

@ravishanker ravishanker commented Mar 28, 2023 •
edited
Loading

Fix #1035 and #1036

This PR updates the following for Android 13

  • targetSdkVersion from 31 to 33
  • Utils version to 3.5.0
  • configure version to 0.6.5

Test

Being able to build and basic smoke test should be enough.

  1. Run AztecDemo app.
  2. Scroll down and find the HTML block (It's shown as "?", below "if (value == 5) printf(value)")
  3. Tap the HTML block and type a long text to increase the dialog size.
  4. Ensure "CANCEL", "SAVE" buttons are still visible and there is a margin between the keyboard and dialog.

Review

@irfano
@fluiddot

Make sure strings will be translated:

  • If there are new strings that have to be translated, I have added them to the client's strings.xml as a part of the integration PR.

@ravishanker
Update targetSdkVersion to 33
de127b2 
Updates targetSdkVersion to 33 for Android 13
@ravishanker
Update Utils version to 3.4.0
8b68094 
Updates Utils version from trunk-1ed207c03d2242b6fc3d74f9e388e9163cbc82a6 to 3.4.0 for Android 13
@ravishanker
Replace jcenter with mavenCentral
114dfe1
@ravishanker
Update configure to 0.6.5
9b26579 
Update configure from 0.6.3 to 0.6.5
@ravishanker ravishanker requested review from fluiddot and irfano March 28, 2023 23:05
@ravishanker ravishanker self-assigned this Mar 28, 2023
@ravishanker ravishanker mentioned this pull request Mar 28, 2023
Closed
@ravishanker
Fix tests
351d717 
Fix tests by removing deprecated AndroidTestCase
@ravishanker
Update Utils version to 3.5.0
30a3fe9
@ravishanker
Replace getExternalStoragePublicDirectory
d42b0de 
Replace deprecated getExternalStoragePublicDirectory on MainActivity
@ravishanker ravishanker mentioned this pull request Mar 29, 2023
Closed
irfano
irfano approved these changes Mar 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating LayoutParams.SOFT_INPUT_ADJUST_RESIZE may be worth a special test. To test:

There is no change about SOFT_INPUT_ADJUST_RESIZE on this PR. I guess it wass added to the description by mistake.

Choosing photos from the device and taking photos via camera features work successfully.
Approved! 👍🏻

@ravishanker ravishanker merged commit 8ce8c78 into trunk Mar 29, 2023
@ravishanker ravishanker deleted the Android-13-Update-targetSdk-to-33 branch March 29, 2023 20:55
@ParaskP7 ParaskP7 mentioned this pull request May 10, 2023
Closed
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@irfano irfano irfano approved these changes

@fluiddot fluiddot Awaiting requested review from fluiddot

Assignees

@ravishanker ravishanker

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade AztecEditor-Android to Android 13

2 participants

@ravishanker @irfano