Merged
Conversation
This change wont impact the library as this change only affects the Example app. This change has to be made to make sure that the CI passes
From Android 12 the exported attribute of the activity has set to be true/false. Some of the test dependencies was having an outdated version which contains activities not having the exported attribute. The version of the test dependencies are incremented in order to make it compatible with Android 12.
42 tasks
fluiddot
approved these changes
Oct 5, 2022
Contributor
fluiddot
left a comment
There was a problem hiding this comment.
I've tested the editor both as a standalone app and using wordpress-mobile/WordPress-Android#17153 branch in WP-Android, I haven't encountered any issue so looks like these changes are good to go 🎊 .
ParaskP7
reviewed
Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1003
This PR updates the
targetSDKversionto 31 for the Android 12 migrationTest Instructions
[x] If there are new strings that have to be translated, I have added them to the client's
strings.xmlas a part of the integration PR.