HTML API: Call $this->is_tag_closer() in HTML Processor.

dmsnell · dmsnell · commit d3c1b41ba150 · 2024-06-08T12:10:42.000Z
The HTML Processor had been calling the parent class `is_tag_closer()` method, but since visiting virtual nodes was introduced, it's important that all of the methods are called on the subclass. This patch fixes one issue identified where the parent method was called instead, and it fixes another case where the change from calling the parent method to the `$this` method was done improperly. Developed in #6726 Discussed in https://core.trac.wordpress.org/ticket/61348 Props jonsurrell. See #61348. Follow-up to [58304]. git-svn-id: https://develop.svn.wordpress.org/trunk@58365 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-includes/html-api/class-wp-html-processor.php b/src/wp-includes/html-api/class-wp-html-processor.php
@@ -429,7 +429,7 @@ public function next_tag( $query = null ) {
 					continue;
 				}
 
-				if ( ! $this::is_tag_closer() || $visit_closers ) {
+				if ( ! $this->is_tag_closer() || $visit_closers ) {
 					return true;
 				}
 			}
@@ -464,7 +464,7 @@ public function next_tag( $query = null ) {
 					continue;
 				}
 
-				if ( ! parent::is_tag_closer() || $visit_closers ) {
+				if ( ! $this->is_tag_closer() || $visit_closers ) {
 					return true;
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -429,7 +429,7 @@ public function next_tag( $query = null ) {`
`429`	`429`	`continue;`
`430`	`430`	`}`
`431`	`431`
`432`		`- if ( ! $this::is_tag_closer() \|\| $visit_closers ) {`
	`432`	`+ if ( ! $this->is_tag_closer() \|\| $visit_closers ) {`
`433`	`433`	`return true;`
`434`	`434`	`}`
`435`	`435`	`}`
`@@ -464,7 +464,7 @@ public function next_tag( $query = null ) {`
`464`	`464`	`continue;`
`465`	`465`	`}`
`466`	`466`
`467`		`- if ( ! parent::is_tag_closer() \|\| $visit_closers ) {`
	`467`	`+ if ( ! $this->is_tag_closer() \|\| $visit_closers ) {`
`468`	`468`	`return true;`
`469`	`469`	`}`
`470`	`470`	`}`