refactor(kitsu-core): initialize deserialisation includes array only a single time #1094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi! Could you please rebase your PR onto the latest master? The tests are currently failing because they rely on a test coverage service that has shutdown and has now been removed on master. Rebasing should resolve the issue. |
781a711 to
42d74fa
Compare
Contributor
Author
|
Hello! Rebased onto the latest master as requested. |
Owner
|
Thank you! I'll get this rolled out to 10.x tomorrow hopefully 🙏 |
Owner
|
Published as https://github.com/wopian/kitsu/releases/tag/v11.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when the request returns a lot of items (for me it was 2.5k), the deserialisation process is really slow.
The issue seems to stem from O(n^2) loop, where for every item in the response, we again loop every item in the response.
The fix looks to resolve it by not redefining the includes for every item separately. This works as
includedis not mutated in thelinkRelationshipsmethod. If there is fear of mutation, spread syntax orincluded.slice()could be used.In my sample (large dataset, no relationships) the deserialisation process goes from taking 2 seconds to 2 ms.