Skip to content

feat(kitsu)!: upgrade axios to v1 #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
benchaikin wants to merge 3 commits into from
Closed

feat(kitsu)!: upgrade axios to v1 #1073

benchaikin wants to merge 3 commits into from

Conversation

@benchaikin
Copy link
Contributor

@benchaikin benchaikin commented Apr 4, 2025

  • Updated marshalling of axios headers in order to preserve behavior when no headers are present
  • Updated marshalling of user data in order to preserve behavior when not present
  • Updating tests to account for axios treating all header values as strings
  • Bumped size limit to account for fatter axios dependency

@benchaikin
Copy link
Contributor Author

benchaikin commented Apr 4, 2025

For some reason Jest's toEqual didn't like expecting axios headers as now they are typed differently. I'm no Jest expert but this seems to be what I would have expected from toStrictEqual, not toEqual. My solution was to move to toMatchObject for these cases, however let me know if there's a more elegant solution or something I'm missing here. Thanks!

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 5, 2025
View reviewed changes
wopian
wopian requested changes Apr 5, 2025
View reviewed changes
@wopian wopian changed the title feat(kitsu): upgrading to latest version of axios feat(kitsu)!: upgrading to latest version of axios Apr 5, 2025
@wopian wopian changed the title feat(kitsu)!: upgrading to latest version of axios feat(kitsu)!: upgrade axios to v1 Apr 5, 2025
@benchaikin benchaikin requested a review from wopian April 8, 2025 15:15
@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Apr 8, 2025

Code Climate has analyzed commit 96fd1d7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@wopian wopian mentioned this pull request Apr 8, 2025
Merged
@wopian wopian closed this in #1075 Apr 8, 2025
@wopian
Copy link
Owner

wopian commented Apr 8, 2025 •
edited
Loading

Thanks! Merged in #1075 as some further code style changes needed to be performed and I don't have write access to your PR in your fork.

@wopian
Copy link
Owner

wopian commented Apr 9, 2025 •
edited
Loading

Released as part of 11.0.0 / 11.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wopian wopian Awaiting requested review from wopian

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benchaikin @wopian