[산군] 뷰 챌린지 미션 3단계 제출합니다.#61
Conversation
1. 팬 구현 2. 직사각형 구현 3. 원 구현
chws0508
left a comment
There was a problem hiding this comment.
저도 영어로 답할게요~
Hello, sangoooooon,
You did a good job of implementing the mission.
I think abstraction was done better than before.
And, the current mission no longer looks like a review is needed.
But, I just saw comments that you left in the previous PR.
So I wrote some replies to that comments.
If you check my replies, and then I merge this PR.
| abstract class DrawableTool( | ||
| open val line: Line, | ||
| private val reset: () -> Unit | ||
| ) : Painter { | ||
|
|
||
| fun setWidth(width: Float) { | ||
| line.brush.changeBrushWidth(width) | ||
| } | ||
|
|
||
| fun setColor(color: Int) { | ||
| line.brush.changeBrushColor(color) | ||
| } | ||
|
|
||
| override fun finishPainting() { | ||
| reset.invoke() | ||
| } | ||
| } |
|
|
||
| abstract class EraseTool : Painter { | ||
|
|
||
| override fun finishPainting() {} |
There was a problem hiding this comment.
저는 개인적으로 함수의 내용이 없다면, Unit 이라는 표현을 쓰는것을 선호합니당
There was a problem hiding this comment.
@DYGames 코건도 이런 식으로 구현하지 않는 인터페이스가 있었던 것 같은데... 🤔
There was a problem hiding this comment.
@woowahan-leah
문제 파악 -> 해결 방안 구상 -> 해결 -> 선한 영향력 전파 (남의 PR에 코멘트 달기)까지..
전 또 성장했습니다...
chws0508
left a comment
There was a problem hiding this comment.
산군 이번 미션 고생 많으셨습니다!
안드 쌩초보시절 만나서 페어를 진행했었는데,
지금 다시 코드 리뷰를 해보니,
산군도 저도 많이 성장한 것 같이 느껴져서 뿌듯하네요ㅎㅎ
남은 우테코 기간 같이 힘내서 같이 더 성장해보도록 해요!
화이팅!!
Hello! scaaaattt!
It's already our last mission :)
I did implement your request that is in last review and reactive UI of dark mode, tablet(landscape, portrait).
Request
Requirements
Selection requirements
Result
tablet(landscape)
tablet(portrait)
darkmode
Have fun with lol !! I'm always rooting for you.
dojo yo ro si ku o ne gai for this mission ! :))