Skip to content
This repository was archived by the owner on Feb 23, 2024. It is now read-only.

Try a transform from Featured Product to Cover#490

Closed
ryelle wants to merge 2 commits into
masterfrom
try/cover-block-transform
Closed

Try a transform from Featured Product to Cover#490
ryelle wants to merge 2 commits into
masterfrom
try/cover-block-transform

Conversation

@ryelle

@ryelle ryelle commented Mar 14, 2019

Copy link
Copy Markdown
Contributor

Fixes #295 – Gutenberg's updates to the Cover block have merged, and should be released in v 5.3 of Gutenberg. That update captures the work we wanted to do with the "Call to Action" block, so this PR adds a transform from our Featured Product into the new Cover block. All customizations except for height should be mapped over.

Currently this is blocked by a technical problem– how to get the data from the API? I can't use an async function because the way this is called, it doesn't wait around for the resolution.

To do:

  • Don't allow the transform if we're not at GB 5.3+
  • Get real product data into the transform

Screenshots

Before (Featured Product block)

before

Picking the transform:

transform

After (Cover block)

after

("with links" text is there ^ it's just blending into the background – you can see the non-link white period at the end of the line)

How to test the changes in this Pull Request:

  1. Add a Featured Product to you post/page
  2. Click the block icon, this will give you the option to transform to the Cover block.
  3. Click the cover icon to do the transform.
  4. Expect: All your showing content should be included in the cover block. Now you can edit the text content as well as the button 👍

Try the above flow a few times, with various customizations on Featured Product– custom image, background color, overlay opacity, button text, color, link…

@ryelle ryelle added this to the Future release milestone Mar 14, 2019
@ryelle ryelle self-assigned this Mar 14, 2019
@ryelle ryelle changed the title Try/cover block transform Try a transform from Featured Product to Cover Mar 14, 2019
@ryelle ryelle force-pushed the try/cover-block-transform branch from 566d16d to 4c66fd5 Compare March 20, 2019 18:46
mikejolley
mikejolley previously approved these changes Jul 1, 2019
@mikejolley

Copy link
Copy Markdown
Member

#295 (comment)

@mikejolley mikejolley closed this Oct 16, 2019
@ralucaStan ralucaStan deleted the try/cover-block-transform branch March 2, 2021 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable transform from "Featured Product" to "Call to Action"

3 participants