This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Try a transform from Featured Product to Cover#490
Closed
ryelle wants to merge 2 commits into
Closed
Conversation
566d16d to
4c66fd5
Compare
4c66fd5 to
0fa5728
Compare
mikejolley
previously approved these changes
Jul 1, 2019
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #295 – Gutenberg's updates to the Cover block have merged, and should be released in v 5.3 of Gutenberg. That update captures the work we wanted to do with the "Call to Action" block, so this PR adds a transform from our Featured Product into the new Cover block. All customizations except for height should be mapped over.
Currently this is blocked by a technical problem– how to get the data from the API? I can't use an async function because the way this is called, it doesn't wait around for the resolution.
To do:
Screenshots
Before (Featured Product block)
Picking the transform:
After (Cover block)
("with links" text is there ^ it's just blending into the background – you can see the non-link white period at the end of the line)
How to test the changes in this Pull Request:
Try the above flow a few times, with various customizations on Featured Product– custom image, background color, overlay opacity, button text, color, link…