Skip to content

[UI Tests] - Update Android emulator model and version#7454

Merged
jostnes merged 15 commits intotrunkfrom
update-android-emulator-firebase
Oct 5, 2022
Merged

[UI Tests] - Update Android emulator model and version#7454
jostnes merged 15 commits intotrunkfrom
update-android-emulator-firebase

Conversation

@jostnes
Copy link
Copy Markdown
Contributor

@jostnes jostnes commented Sep 27, 2022

Closes: #7447

Description

This PR updates the emulator version that the instrumented tests on FTL are running on. From testing, found that Pixel 3 API 30 runs the test really slow so will exclude that device for now. There are also some changes needed if we remain to use the current Pixel 2 device.

There is Pixel 2 (ARM) emulator that supports multiple APIs including newer ones. I tested that out and it runs the tests well without requiring any other code changes. Will update the tests to use that device with API 30 (Android 11) as it is currently the most used version.

Testing instructions

All instrumented tests should pass locally and in CI.

Images/gif

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jostnes jostnes added type: task An internally driven task. category: ui tests Related to UI testing. labels Sep 27, 2022
@wpmobilebot
Copy link
Copy Markdown
Collaborator

wpmobilebot commented Sep 27, 2022

You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:

@jostnes jostnes mentioned this pull request Sep 28, 2022
1 task
@jostnes jostnes added this to the 10.7 milestone Oct 3, 2022
@jostnes jostnes requested review from a team, ParaskP7 and pachlava October 3, 2022 10:04
@jostnes jostnes marked this pull request as ready for review October 3, 2022 10:05
Copy link
Copy Markdown
Contributor

@pachlava pachlava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jostnes 👋

This is a kind of PR for which it's enough to see that the execution on FTL is 🟢 - and it is 👍

Just curious - why didn't you go for API 32? The tests passed on it too, and the execution time is only 9 seconds slower. Is it because of the error seen in the log? Is this a persistent error?

Thanks!

@jostnes
Copy link
Copy Markdown
Contributor Author

jostnes commented Oct 5, 2022

Thanks for the review @pachlava !

Just curious - why didn't you go for API 32? The tests passed on it too, and the execution time is only 9 seconds slower. Is it because of the error seen in the log? Is this a persistent error?

I was thinking since Android 11 is the most used OS for the app right now, we can start with that first and do an incremental update. I also know most of our real device testing is done on Android 12 (API 31/32) and not Android 11 (API 30). I tested on API 32 to know that if we do decide to update it to that later, it will be an easy change. I'm going to sound terrible but I actually did not notice the error you shared 😬

@jostnes jostnes merged commit 22d29f2 into trunk Oct 5, 2022
@jostnes jostnes deleted the update-android-emulator-firebase branch October 5, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: ui tests Related to UI testing. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI Tests] - Update Android emulator version in Firebase

3 participants