Closed
Conversation
1 task
Collaborator
|
Found 1 violations: The PR caused the following dependency changes:-+--- androidx.constraintlayout:constraintlayout:2.1.1
-| +--- androidx.appcompat:appcompat:1.2.0 -> 1.4.0
-| | +--- androidx.annotation:annotation:1.3.0
-| | +--- androidx.core:core:1.7.0 (*)
-| | +--- androidx.cursoradapter:cursoradapter:1.0.0 (*)
-| | +--- androidx.activity:activity:1.2.4 -> 1.3.1 (*)
-| | +--- androidx.fragment:fragment:1.3.6 -> 1.4.0-rc01 (*)
-| | +--- androidx.appcompat:appcompat-resources:1.4.0
-| | | +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
-| | | +--- androidx.annotation:annotation:1.2.0 -> 1.3.0
-| | | +--- androidx.core:core:1.0.1 -> 1.7.0 (*)
-| | | +--- androidx.vectordrawable:vectordrawable:1.1.0
-| | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-| | | | +--- androidx.core:core:1.1.0 -> 1.7.0 (*)
-| | | | \--- androidx.collection:collection:1.1.0 (*)
-| | | \--- androidx.vectordrawable:vectordrawable-animated:1.1.0
-| | | +--- androidx.vectordrawable:vectordrawable:1.1.0 (*)
-| | | +--- androidx.interpolator:interpolator:1.0.0 (*)
-| | | \--- androidx.collection:collection:1.1.0 (*)
-| | +--- androidx.drawerlayout:drawerlayout:1.0.0 -> 1.1.1 (*)
-| | +--- androidx.savedstate:savedstate:1.1.0 (*)
-| | +--- androidx.emoji2:emoji2:1.0.0
-| | | +--- androidx.collection:collection:1.1.0 (*)
-| | | +--- androidx.annotation:annotation:1.2.0 -> 1.3.0
-| | | +--- androidx.lifecycle:lifecycle-process:2.4.0
-| | | | +--- androidx.lifecycle:lifecycle-runtime:2.4.0 (*)
-| | | | \--- androidx.startup:startup-runtime:1.0.0
-| | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-| | | | \--- androidx.tracing:tracing:1.0.0 (*)
-| | | +--- androidx.core:core:1.3.0 -> 1.7.0 (*)
-| | | \--- androidx.startup:startup-runtime:1.0.0 (*)
-| | +--- androidx.emoji2:emoji2-views-helper:1.0.0
-| | | +--- androidx.emoji2:emoji2:1.0.0 (*)
-| | | +--- androidx.collection:collection:1.1.0 (*)
-| | | \--- androidx.core:core:1.3.0 -> 1.7.0 (*)
-| | +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
-| | +--- androidx.lifecycle:lifecycle-runtime:2.3.1 -> 2.4.0 (*)
-| | +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.4.0 (*)
-| | \--- androidx.resourceinspection:resourceinspection-annotation:1.0.0
-| | \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-| +--- androidx.core:core:1.3.2 -> 1.7.0 (*)
-| \--- androidx.constraintlayout:constraintlayout-core:1.0.1
++--- androidx.constraintlayout:constraintlayout:2.1.2
+| +--- androidx.appcompat:appcompat:1.2.0 -> 1.4.0
+| | +--- androidx.annotation:annotation:1.3.0
+| | +--- androidx.core:core:1.7.0 (*)
+| | +--- androidx.cursoradapter:cursoradapter:1.0.0 (*)
+| | +--- androidx.activity:activity:1.2.4 -> 1.3.1 (*)
+| | +--- androidx.fragment:fragment:1.3.6 -> 1.4.0-rc01 (*)
+| | +--- androidx.appcompat:appcompat-resources:1.4.0
+| | | +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
+| | | +--- androidx.annotation:annotation:1.2.0 -> 1.3.0
+| | | +--- androidx.core:core:1.0.1 -> 1.7.0 (*)
+| | | +--- androidx.vectordrawable:vectordrawable:1.1.0
+| | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+| | | | +--- androidx.core:core:1.1.0 -> 1.7.0 (*)
+| | | | \--- androidx.collection:collection:1.1.0 (*)
+| | | \--- androidx.vectordrawable:vectordrawable-animated:1.1.0
+| | | +--- androidx.vectordrawable:vectordrawable:1.1.0 (*)
+| | | +--- androidx.interpolator:interpolator:1.0.0 (*)
+| | | \--- androidx.collection:collection:1.1.0 (*)
+| | +--- androidx.drawerlayout:drawerlayout:1.0.0 -> 1.1.1 (*)
+| | +--- androidx.savedstate:savedstate:1.1.0 (*)
+| | +--- androidx.emoji2:emoji2:1.0.0
+| | | +--- androidx.collection:collection:1.1.0 (*)
+| | | +--- androidx.annotation:annotation:1.2.0 -> 1.3.0
+| | | +--- androidx.lifecycle:lifecycle-process:2.4.0
+| | | | +--- androidx.lifecycle:lifecycle-runtime:2.4.0 (*)
+| | | | \--- androidx.startup:startup-runtime:1.0.0
+| | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+| | | | \--- androidx.tracing:tracing:1.0.0 (*)
+| | | +--- androidx.core:core:1.3.0 -> 1.7.0 (*)
+| | | \--- androidx.startup:startup-runtime:1.0.0 (*)
+| | +--- androidx.emoji2:emoji2-views-helper:1.0.0
+| | | +--- androidx.emoji2:emoji2:1.0.0 (*)
+| | | +--- androidx.collection:collection:1.1.0 (*)
+| | | \--- androidx.core:core:1.3.0 -> 1.7.0 (*)
+| | +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
+| | +--- androidx.lifecycle:lifecycle-runtime:2.3.1 -> 2.4.0 (*)
+| | +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.4.0 (*)
+| | \--- androidx.resourceinspection:resourceinspection-annotation:1.0.0
+| | \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+| +--- androidx.core:core:1.3.2 -> 1.7.0 (*)
+| \--- androidx.constraintlayout:constraintlayout-core:1.0.2
-+--- androidx.recyclerview:recyclerview:1.1.0
-| +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-| +--- androidx.core:core:1.1.0 -> 1.7.0 (*)
-| +--- androidx.customview:customview:1.0.0 -> 1.1.0 (*)
-| \--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
++--- androidx.recyclerview:recyclerview:1.2.1
+| +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+| +--- androidx.core:core:1.3.2 -> 1.7.0 (*)
+| +--- androidx.customview:customview:1.0.0 -> 1.1.0 (*)
+| \--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
+--- androidx.recyclerview:recyclerview-selection:1.1.0
-| \--- androidx.recyclerview:recyclerview:1.1.0 (*)
+| \--- androidx.recyclerview:recyclerview:1.1.0 -> 1.2.1 (*)
+--- com.google.android.material:material:1.4.0
-| +--- androidx.constraintlayout:constraintlayout:2.0.1 -> 2.1.1 (*)
+| +--- androidx.constraintlayout:constraintlayout:2.0.1 -> 2.1.2 (*)
-| +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.1.0 (*)
+| +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.2.1 (*)
| \--- androidx.viewpager2:viewpager2:1.0.0
-| \--- androidx.recyclerview:recyclerview:1.1.0 (*)
+| \--- androidx.recyclerview:recyclerview:1.1.0 -> 1.2.1 (*)
+--- androidx.preference:preference:1.1.1
-| \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.1.0 (*)
+| \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.2.1 (*)
+--- org.wordpress:utils:develop-358e582786c11d6d5ae5a351c2ad5475a3376ece
-| \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.1.0 (*)
+| \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.2.1 (*)
+--- org.wordpress:fluxc:develop-e490ac0557848d32e28781e7f8fca4923e587a98
| +--- androidx.paging:paging-runtime:2.1.2
-| | \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.1.0 (*)
+| | \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.2.1 (*)
-| \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.1.0 (*)
+| \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.2.1 (*)
+--- org.wordpress:login:0.10.0
-| \--- androidx.constraintlayout:constraintlayout:2.0.4 -> 2.1.1 (*)
+| \--- androidx.constraintlayout:constraintlayout:2.0.4 -> 2.1.2 (*)
+--- com.zendesk:support:5.0.3
| +--- com.zendesk:guide:1.0.2
-| | \--- androidx.recyclerview:recyclerview -> 1.1.0 (*)
+| | \--- androidx.recyclerview:recyclerview -> 1.2.1 (*)
-| \--- androidx.recyclerview:recyclerview -> 1.1.0 (*)
+| \--- androidx.recyclerview:recyclerview -> 1.2.1 (*)
\--- org.wordpress:mediapicker:trunk-4da42c711820c4b2e83b7735fbb39dbcf8c9176c
- \--- androidx.constraintlayout:constraintlayout:2.1.1 (*)
+ \--- androidx.constraintlayout:constraintlayout:2.1.1 -> 2.1.2 (*)
Please review and act accordingly
|
|
You can test the changes on this Pull Request by downloading the APK here. |
Contributor
|
I'm not sure I'm a fan of the working reporting this as a violation — which to me suggests something is a wrong and needs to be reverted or fixed — as opposed to calling it a warning — as in "just wanted to highlight this and let you know, and maybe make sure you take extra care of testing that this didn't break anything" |
Contributor
Author
|
@AliSoftware totally agree
comes from |
Contributor
|
Using our Buildkite's |
Contributor
Author
|
@AliSoftware Can it also remove a comment if it's not necessary anymore? Will it keep 1 comment per PR too? |
Contributor
|
Ah good point. Our fastlane action (which we have just started to use on Buildkite CI) can update an existing comment (we just have to provide the same arbitrary identifier every time we call it), but don't currently provide the ability to delete one. But that should be a pretty straightforward addition to implement in that action though (eg if we call the action with a reuse_identifier and a nil comment body, delete the comment instead of updating it with empty text, something like that) so that shouldn't be a blocker. |
Generated by 🚫 dangerJS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dummy PR to test dependency diff
#5420