Merged
Conversation
The most recent designs call for the image to be above the text. Since the login library is shared, the closest I could get was to override the dialog content layout - but cannot include the title arrangement changes since that's set on the dialog in the login library.
|
You can test the changes on this Pull Request by downloading the APK here. |
Contributor
Author
|
Actually, let me take another look at this. Since it's just a title, moving it all into the view may not be a big deal... |
Generated by 🚫 dangerJS |
1 task
This was referenced May 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2325 by overriding the site address help dialog to better match designs. The most recent designs call for the image to be on top, then the title, then the body. Since the login library is shared, the closest I could get was to override the dialog content layout which places the image above the body - but cannot move the title since that's set in the login library when setting the alert dialog title.
@Garance91540
This is the closest I could get by overriding the login library layout. The dialog text is set programmatically in the login library and that's where android places the title - so overriding the layout only changes the body and image arrangement. Ideally we'd not be overriding layout files just because it then makes it difficult to track where to make changes, but if you think the changes are worth it, we can push it. Here are the comparisons:Never mind! I figured out a clean way to do this :) I just check if the login mode is "Woo" and only add the title if it's not. This way we could add the title to the layout as well. Updated the screenshots. I also updated the dialog theme to fix the padding on the button bars so they are 24dp.
Update release notes:
RELEASE-NOTES.txtif necessary.