Dark Mode: Cleanup Stragglers and minor views#2262
Merged
anitaa1990 merged 12 commits intodevelopfrom Apr 17, 2020
Merged
Conversation
added 11 commits
April 16, 2020 16:30
This just fixes something I did early on but have since learned is not necessary. Dialogs don't need to be contained in a card, the theme will take care of the surface and elevation for us - so the extra layer in the view hierarchy is just dead weight and a performance hit.
This view is not currently being used, but it's helpful to have it finished.
This isn't currently in use, but since I'm removing old assets this needed to be converted as well.
Generated by 🚫 dangerJS |
|
You can test the changes on this Pull Request by downloading the APK here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another round of cleanup! This time doing a search and replace for
<TextView/>and<AppCompatButton/>to update with the material versions, which led to minor changes in classes already converted, as well as updating some views that hadn't yet been converted:Refund by item view
This view is not actively being used so the screenshots are just from the layout preview. This was needed to ensure the deprecated styles were removed. When we switch back to using this view we can tweak it if needed.
Dashboard Notice Card
Another view not actively in use, but I'm sure we're keeping it because we will use it again in the future. These screenshots are also from the layout preview. Since all the styles are standard we should be fine with these changes and can tweak if needed when we next use it.
Custom Progres Dialog
This view was already converted, but back when I made these changes I was still learning and have since figured out that the
MaterialCardViewis not necessary for dialogs - the OS will take care of the surface and elevations. So I removed that extra layer of hierarchy for performance reasons.