Skip to content

Added logic to fetch the correct SiteModel from the local db for the incoming url#1756

Merged
nbradbury merged 1 commit intodevelopfrom
issue/1730-login-site-picker-fix
Dec 24, 2019
Merged

Added logic to fetch the correct SiteModel from the local db for the incoming url#1756
nbradbury merged 1 commit intodevelopfrom
issue/1730-login-site-picker-fix

Conversation

@anitaa1990
Copy link
Copy Markdown
Contributor

@anitaa1990 anitaa1990 commented Dec 24, 2019

Fixes #1730. This PR adds logic to fetch the correct SiteModel for the stored site address in the Site Picker screen.

Screenshots

(LEFT: Before . RIGHT: After)
.

Testing

  • Login to a test site and verify that you are logged in successfully to the correct site.
  • Logout of the app.
  • Now login to a different test site with a similar name/url to the site entered in step 1.
  • Note that you are logged in to the site entered in step 1 when, in fact, you should be redirected to the site in step 3.

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@anitaa1990 anitaa1990 added type: bug A confirmed bug. Login labels Dec 24, 2019
@anitaa1990 anitaa1990 added this to the 3.4 milestone Dec 24, 2019
@peril-woocommerce
Copy link
Copy Markdown

peril-woocommerce bot commented Dec 24, 2019

Messages
📖

This PR contains changes in the subtree libs/login/. It is your responsibility to ensure these changes are merged back into wordpress-mobile/WordPress-Login-Flow-Android. Follow these handy steps!
WARNING: Make sure your git version is 2.19.x or lower - there is currently a bug in later versions that will corrupt the subtree history!

  1. cd woocommerce-android
  2. git checkout issue/1730-login-site-picker-fix
  3. git subtree push --prefix=libs/login/ https://github.com/wordpress-mobile/WordPress-Login-Flow-Android.git merge/woocommerce-android/1756
  4. Browse to https://github.com/wordpress-mobile/WordPress-Login-Flow-Android/pull/new/merge/woocommerce-android/1756 and open a new PR.

Generated by 🚫 dangerJS

@peril-woocommerce
Copy link
Copy Markdown

peril-woocommerce bot commented Dec 24, 2019

You can test the changes on this Pull Request by downloading the APK here.

@nbradbury nbradbury self-assigned this Dec 24, 2019
@nbradbury nbradbury self-requested a review December 24, 2019 13:43
nbradbury
nbradbury approved these changes Dec 24, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@nbradbury nbradbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nbradbury nbradbury merged commit bc3b9d9 into develop Dec 24, 2019
@nbradbury nbradbury deleted the issue/1730-login-site-picker-fix branch December 24, 2019 13:44
This was referenced May 23, 2020
Merged
Merged
@designsimply designsimply added feature: login Related to any part of the log in or sign in flow, or authentication. and removed Login labels May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbradbury nbradbury nbradbury approved these changes

Assignees

@nbradbury nbradbury

Labels

feature: login Related to any part of the log in or sign in flow, or authentication. type: bug A confirmed bug.

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

Woo Login: Incorrect site selected in Site picker screen during auto login in

3 participants

@anitaa1990 @nbradbury @designsimply