Skip to content

Bug fix: Lost Password link on self-hosted credentials screen doesn't work#1589

Merged
nbradbury merged 2 commits intorelease/3.1from
hotfix/3.1-login-password-fix
Nov 20, 2019
Merged

Bug fix: Lost Password link on self-hosted credentials screen doesn't work#1589
nbradbury merged 2 commits intorelease/3.1from
hotfix/3.1-login-password-fix

Conversation

@anitaa1990
Copy link
Copy Markdown
Contributor

@anitaa1990 anitaa1990 commented Nov 20, 2019

Fixes #1576. The forgot password link in the self hosted credentials link was malformed. This PR adds logic to fix this issue.

Testing

  • Open the app while logged out, and select Log In.
  • Enter the URL for a WooCommerce store with Jetpack connected.
  • Select the option to "log in with site credentials."
  • On the site credentials screen, select "Lost your password?" and note the message that appears.
  • Pull changes from this PR and verify that the forgot password link is working.

@rachelmcr, adding you as a reviewer since you caught the bug :)

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@anitaa1990 anitaa1990 added type: bug A confirmed bug. Login labels Nov 20, 2019
@anitaa1990 anitaa1990 added this to the 3.1 ❄️ milestone Nov 20, 2019
@peril-woocommerce
Copy link
Copy Markdown

peril-woocommerce bot commented Nov 20, 2019

Messages
📖

This PR contains changes in the subtree libs/login/. It is your responsibility to ensure these changes are merged back into wordpress-mobile/WordPress-Login-Flow-Android. Follow these handy steps!
WARNING: Make sure your git version is 2.19.x or lower - there is currently a bug in later versions that will corrupt the subtree history!

  1. cd woocommerce-android
  2. git checkout hotfix/3.1-login-password-fix
  3. git subtree push --prefix=libs/login/ https://github.com/wordpress-mobile/WordPress-Login-Flow-Android.git merge/woocommerce-android/1589
  4. Browse to https://github.com/wordpress-mobile/WordPress-Login-Flow-Android/pull/new/merge/woocommerce-android/1589 and open a new PR.

Generated by 🚫 dangerJS

@peril-woocommerce
Copy link
Copy Markdown

peril-woocommerce bot commented Nov 20, 2019 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

@nbradbury nbradbury self-assigned this Nov 20, 2019
nbradbury
nbradbury approved these changes Nov 20, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@nbradbury nbradbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is good! :shipit:

@nbradbury nbradbury merged commit 82549ce into release/3.1 Nov 20, 2019
@0nko 0nko deleted the hotfix/3.1-login-password-fix branch November 21, 2019 22:48
@anitaa1990 anitaa1990 mentioned this pull request Dec 4, 2019
Closed
3 tasks
This was referenced May 23, 2020
Merged
Merged
@designsimply designsimply added feature: login Related to any part of the log in or sign in flow, or authentication. and removed Login labels May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbradbury nbradbury nbradbury approved these changes

@0nko 0nko Awaiting requested review from 0nko

@rachelmcr rachelmcr Awaiting requested review from rachelmcr

Assignees

@nbradbury nbradbury

Labels

feature: login Related to any part of the log in or sign in flow, or authentication. type: bug A confirmed bug.

Projects

None yet

Milestone

3.1

Development

Successfully merging this pull request may close these issues.

3 participants

@anitaa1990 @nbradbury @designsimply