Skip to content

Modified logic to read from raw folder for webview#1281

Merged
nbradbury merged 1 commit intorelease/2.3from
issue/1278-license-page-blank-fix
Jul 24, 2019
Merged

Modified logic to read from raw folder for webview#1281
nbradbury merged 1 commit intorelease/2.3from
issue/1278-license-page-blank-fix

Conversation

@anitaa1990
Copy link
Copy Markdown
Contributor

Fixes #1278 . This PR modifies the logic to read the local Licenses HTML page from the raw folder to fix the issue of the page not loading in a release build.

Testing

  • Verify that the licenses page is displayed correctly in the debug build and the release build.
  • Change the device language to something else and verify that the English version of the page is still displayed. This is to verify that the license page is loaded even without the translation.
  • The file needs to be translated to verify that localisation works. But I was able to manually add a translated HTML file for French and verify that it is working correctly.

Screenshots

.

cc @loremattei

@anitaa1990 anitaa1990 added type: bug A confirmed bug. feature: app settings Related to settings accessed via the gear icon in the My Store section. labels Jul 24, 2019
@anitaa1990 anitaa1990 added this to the 2.3 ❄️ milestone Jul 24, 2019
@anitaa1990 anitaa1990 requested a review from nbradbury July 24, 2019 16:59
@nbradbury
Copy link
Copy Markdown
Contributor

Looks good! :shipit:

@nbradbury nbradbury merged commit 2d29ef7 into release/2.3 Jul 24, 2019
@nbradbury nbradbury deleted the issue/1278-license-page-blank-fix branch July 24, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: app settings Related to settings accessed via the gear icon in the My Store section. type: bug A confirmed bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants