Skip to content

[Dynamic Dashboard] Reviews card UI#11491

Merged
hichamboushaba merged 15 commits intotrunkfrom
issue/11474-dynamic-dashboard-reviews-card-2
May 15, 2024
Merged

[Dynamic Dashboard] Reviews card UI#11491
hichamboushaba merged 15 commits intotrunkfrom
issue/11474-dynamic-dashboard-reviews-card-2

Conversation

@hichamboushaba
Copy link
Copy Markdown
Member

@hichamboushaba hichamboushaba commented May 13, 2024 •
edited
Loading

Part of: #11474

Description

This PR adds the following:

  • UI State of the reviews card.
  • Content state of reviews card.
  • Empty state for the reviews card.
  • Logic to navigate to the reviews list from the card.

Testing instructions

  1. Open the app.
  2. Enable the reviews card if needed.
  3. Confirm the card works correctly.
  4. Change the filter option.
  5. Confirm the list of reviews shown is updated accordingly.

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@hichamboushaba hichamboushaba added type: enhancement A request for an enhancement. feature: dashboard Related to home screen project labels May 13, 2024
@dangermattic
Copy link
Copy Markdown
Collaborator

dangermattic commented May 13, 2024 •
edited
Loading

2 Warnings
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ This PR is assigned to the milestone 18.7. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@hichamboushaba hichamboushaba force-pushed the issue/11474-dynamic-dashboard-reviews-card-2 branch from c35cfbc to edc00f1 Compare May 13, 2024 09:20
@wpmobilebot
Copy link
Copy Markdown
Collaborator

wpmobilebot commented May 13, 2024 •
edited
Loading

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commit67717c7
Direct Downloadwoocommerce-prototype-build-pr11491-67717c7.apk

@hichamboushaba hichamboushaba marked this pull request as ready for review May 13, 2024 13:44
@hichamboushaba hichamboushaba requested a review from a team as a code owner May 13, 2024 13:44
@hichamboushaba hichamboushaba requested a review from 0nko May 13, 2024 13:44
@hichamboushaba hichamboushaba added this to the 18.7 milestone May 13, 2024
@hichamboushaba hichamboushaba mentioned this pull request May 13, 2024
Closed
@hichamboushaba hichamboushaba force-pushed the issue/11474-dynamic-dashboard-reviews-card-2 branch from c041e55 to 67717c7 Compare May 14, 2024 18:05
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 196 lines in your changes are missing coverage. Please review.

Project coverage is 40.67%. Comparing base (f873268) to head (67717c7).
Report is 59 commits behind head on trunk.

Files Patch % Lines
...droid/ui/dashboard/reviews/DashboardReviewsCard.kt 0.00% 163 Missing ⚠️
.../ui/dashboard/reviews/DashboardReviewsViewModel.kt 0.00% 24 Missing ⚠️
...ce/android/ui/dashboard/data/DashboardDataStore.kt 0.00% 9 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##              trunk   #11491      +/-   ##
============================================
- Coverage     40.78%   40.67%   -0.11%     
  Complexity     5180     5180              
============================================
  Files          1070     1070              
  Lines         62374    62540     +166     
  Branches       8521     8557      +36     
============================================
  Hits          25438    25438              
- Misses        34649    34815     +166     
  Partials       2287     2287

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hichamboushaba hichamboushaba mentioned this pull request May 15, 2024
Merged
@0nko 0nko self-assigned this May 15, 2024
0nko
0nko approved these changes May 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look and works great! :shipit:

Base automatically changed from issue/11474-dynamic-dashboard-reviews-card to trunk May 15, 2024 16:11
@hichamboushaba hichamboushaba merged commit c230ce5 into trunk May 15, 2024
@hichamboushaba hichamboushaba deleted the issue/11474-dynamic-dashboard-reviews-card-2 branch May 15, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@0nko 0nko 0nko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@0nko 0nko

Labels

feature: dashboard Related to home screen project type: enhancement A request for an enhancement.

Projects

None yet

Milestone

18.7

Development

Successfully merging this pull request may close these issues.

5 participants

@hichamboushaba @dangermattic @wpmobilebot @codecov-commenter @0nko