Merged
Conversation
Collaborator
Generated by 🚫 Danger |
Collaborator
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #11475 +/- ##
============================================
- Coverage 40.88% 40.88% -0.01%
Complexity 5180 5180
============================================
Files 1067 1067
Lines 62206 62210 +4
Branches 8483 8484 +1
============================================
+ Hits 25436 25437 +1
- Misses 34484 34486 +2
- Partials 2286 2287 +1 ☔ View full report in Codecov by Sentry. |
9eebdb2 to
ee0f775
Compare
hichamboushaba
commented
May 9, 2024
| widgets.add( | ||
| DashboardWidgetDataModel.newBuilder() | ||
| .setType(type.name) | ||
| .setIsAdded(false) |
Member
Author
There was a problem hiding this comment.
This and the value in getDefaultWidgets should be updated after taking a decision internally p1715271583741779-slack-C03L1NF1EA3
# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/util/FeatureFlag.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new feature flag for the M2 changes, and updates the datastore with logic needed to filter out new widgets during development, and also to add them when they are supported but not available in the saved config.
Testing instructions
Just code review.
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.