Skip to content

Dynamic dashboard/UI tests#11454

Merged
hichamboushaba merged 13 commits intotrunkfrom
dynamic-dashboard/ui-tests
May 7, 2024
Merged

Dynamic dashboard/UI tests#11454
hichamboushaba merged 13 commits intotrunkfrom
dynamic-dashboard/ui-tests

Conversation

@hichamboushaba
Copy link
Copy Markdown
Member

@hichamboushaba hichamboushaba commented May 6, 2024

Closes: #11453

Description

This PR updates the UI tests to align with the dynamic dashboard changes.

Please feel free to share any np comments in the review, I don't have a lot of experience with UI tests especially ones that involve Compose, and if we can improve anything it would be great.

Testing instructions

Just green CI.

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@hichamboushaba hichamboushaba added category: ui tests Related to UI testing. feature: dashboard Related to home screen project labels May 6, 2024
@dangermattic
Copy link
Copy Markdown
Collaborator

dangermattic commented May 6, 2024

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Copy Markdown
Collaborator

wpmobilebot commented May 6, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commit2be7aaa
Direct Downloadwoocommerce-prototype-build-pr11454-2be7aaa.apk

@hichamboushaba hichamboushaba added the status: do not merge Dependent on another PR, ready for review but not ready for merge. label May 6, 2024
@hichamboushaba hichamboushaba marked this pull request as ready for review May 6, 2024 19:22
@hichamboushaba hichamboushaba requested a review from a team as a code owner May 6, 2024 19:22
@hichamboushaba hichamboushaba requested review from 0nko and removed request for a team May 6, 2024 19:23
@0nko 0nko self-assigned this May 7, 2024
Copy link
Copy Markdown
Contributor

@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from dynamic-dashboard/align-cards to trunk May 7, 2024 12:39
@hichamboushaba hichamboushaba removed the status: do not merge Dependent on another PR, ready for review but not ready for merge. label May 7, 2024
@hichamboushaba hichamboushaba enabled auto-merge May 7, 2024 14:22
@hichamboushaba hichamboushaba merged commit 9bbf58a into trunk May 7, 2024
@hichamboushaba hichamboushaba deleted the dynamic-dashboard/ui-tests branch May 7, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: ui tests Related to UI testing. feature: dashboard Related to home screen project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dynamic Dashboard] Update UI Tests

4 participants