Fix crash when using shortcuts while no site is selected yet#10458
Merged
JorgeMucientes merged 2 commits intotrunkfrom Dec 20, 2023
Merged
Fix crash when using shortcuts while no site is selected yet#10458JorgeMucientes merged 2 commits intotrunkfrom
JorgeMucientes merged 2 commits intotrunkfrom
Conversation
The shortcut will be handled once the user selects a site
Collaborator
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Collaborator
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #10458 +/- ##
=========================================
Coverage 41.75% 41.76%
- Complexity 4937 4939 +2
=========================================
Files 998 998
Lines 56360 56361 +1
Branches 7500 7500
=========================================
+ Hits 23533 23537 +4
+ Misses 30735 30733 -2
+ Partials 2092 2091 -1 ☔ View full report in Codecov by Sentry. |
Generated by 🚫 dangerJS |
JorgeMucientes
approved these changes
Dec 20, 2023
Contributor
|
Thanks for handling the crash @hichamboushaba, code looks good and fixes the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #10150 Closes: #10320
Description
This PR fixes an issue where the app will crash when the user attempts to use shortcuts but not site has been selected yet.
Testing instructions
RELEASE-NOTES.txtif necessary.