[3.6] Fix product class name theme conflict due to missing global#23377
Merged
mikejolley merged 6 commits intomasterfrom Apr 24, 2019
Merged
[3.6] Fix product class name theme conflict due to missing global#23377mikejolley merged 6 commits intomasterfrom
mikejolley merged 6 commits intomasterfrom
Conversation
3 tasks
Codecov Report
|
claudiosanches
approved these changes
Apr 23, 2019
Contributor
claudiosanches
left a comment
There was a problem hiding this comment.
Good work!
This is keep backwards compatibility now.
Co-Authored-By: Dragoș Mocrii <dragosmocrii@users.noreply.github.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23374
In 3.5.x
wc_get_product_classused get_post when grabbing the post/product objects.get_postpulls the global $post if null (https://developer.wordpress.org/reference/functions/get_post/).In 3.6.x this was switched to just
wc_get_productwhich does not use the global.This lead to themes which uses
wc_product_classwithout passing a product object to have missing CSS class names. Core is unaffected because it passes the $product object to this function.To test, try the theme zip in #23374. On the shop page, results should be styled correctly and have classes such as 'product type-product' in the markup.