Trigger a country select change on initial load#21733
Merged
claudiulodro merged 1 commit intomasterfrom Oct 30, 2018
Merged
Conversation
…ired on first page load.
claudiulodro
approved these changes
Oct 29, 2018
Contributor
claudiulodro
left a comment
There was a problem hiding this comment.
This looks good to me and works well. Other than whitespace, the only real difference is the addition of $( '#billing_country' ).trigger( 'change' );, correct? Just want to make sure I didn't miss anything when comparing the diffs.
Contributor
Author
|
Yes, that line is the actual fix. I had to fix a bunch of linting errors as well as it was failing hence all the other indentation fixes. |
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR fixes an issue where the address-i18n.js was not firing on initial page loads due to it only being tied to the country on change event causing priority and other local info to be missing.
To remedy this I simply trigger an onchange event on page load to ensure it fires and apply the correct locale info.
Closes #21642
How to test the changes in this Pull Request:
Other information:
Changelog entry