Skip to content

Conversation

@holtrop
Copy link

@holtrop holtrop commented Jun 6, 2025

Description

Reseed DRBG in RAND_poll() and add fork test
Fixes ZD#20016

Testing

  • Ran the r0 test application from ZD#20016 before and after the fix.
  • Added fork test and make check.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@holtrop holtrop self-assigned this Jun 6, 2025
@holtrop holtrop force-pushed the reseed-drbg-in-rand-poll-test branch 3 times, most recently from 6d3f549 to 5dd349d Compare June 6, 2025 14:49
@holtrop holtrop mentioned this pull request Jun 6, 2025
4 tasks
@holtrop holtrop force-pushed the reseed-drbg-in-rand-poll-test branch from 5dd349d to 892167e Compare June 6, 2025 16:23
@holtrop holtrop assigned wolfSSL-Bot and unassigned holtrop Jun 6, 2025
@JacobBarthelmeh JacobBarthelmeh changed the title Reseed DRBG in RAND_poll() and add fork test Add additional compatibility layer RAND tests Jun 6, 2025
JacobBarthelmeh
JacobBarthelmeh previously approved these changes Jun 6, 2025
Copy link
Contributor

@JacobBarthelmeh JacobBarthelmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to see the extra commit get removed before merged to avoid git history snarls or duplicate commits.

@holtrop holtrop dismissed JacobBarthelmeh’s stale review June 6, 2025 21:05

The merge-base changed after approval.

@holtrop holtrop force-pushed the reseed-drbg-in-rand-poll-test branch from 892167e to 10b3cc8 Compare June 7, 2025 00:45
@holtrop holtrop assigned holtrop and unassigned wolfSSL-Bot Jun 7, 2025
@holtrop
Copy link
Author

holtrop commented Jun 7, 2025

retest this please

@holtrop holtrop removed their assignment Jun 7, 2025
@holtrop
Copy link
Author

holtrop commented Jun 7, 2025

Would like to see the extra commit get removed before merged to avoid git history snarls or duplicate commits.

Rebased just the one test addition commit onto master.

JacobBarthelmeh
JacobBarthelmeh previously approved these changes Jun 9, 2025
@holtrop
Copy link
Author

holtrop commented Jun 9, 2025

retest this please

JacobBarthelmeh
JacobBarthelmeh previously approved these changes Jun 9, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the compatibility layer RAND tests by reseeding DRBG in RAND_poll() and adding a fork test to validate behavior in a multi-process context.

  • Added Linux-specific includes.
  • Implemented a new test function, test_wolfSSL_RAND_poll.
  • Registered the new test in the test case array.

@holtrop
Copy link
Author

holtrop commented Jun 10, 2025

retest this please

@JacobBarthelmeh JacobBarthelmeh merged commit eb3c324 into wolfSSL:master Jun 10, 2025
262 of 264 checks passed
@holtrop holtrop deleted the reseed-drbg-in-rand-poll-test branch July 18, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants