20230617-builtin-actions #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…totype arguments (typically void * versus some struct pointer).
…l of action_results and route flag bits, and add a first built-in action. for details, see ChangeLog.md entry for version 1.4.0.
fcdd908 to
af9ee0c
Compare
wolfsentry_action_insert() and wolfsentry_event_insert(): fix WOLFSENTRY_SUCCESS_CODE_IS() uses to use intermediate variable to avoid multiple-evaluation; WOLFSENTRY_ERROR_DECODE_ERROR_CODE() and friends: add gnuish variants that evaluate first arg only once, to fix unittest.c calls that depend on them.
…rors if WOLFSENTRY_ACTION_RES_DELETE is set.
…ry_event_get_aux_event(), wolfsentry_event_get_label(), wolfsentry_addr_family_max_addr_bits(); fix bugprone-switch-missing-default-case warnings from clang-tidy pre20230717 (refactored wolfsentry_rwlock.state back to an enum; refactored JSON_PARSER.automaton to an enum; added default cases elsewhere).
…N_RES_INSERTED, and fix setting of WOLFSENTRY_ACTION_RES_FALLTHROUGH; add unit tests for wolfsentry_event_set_aux_event(), wolfsentry_event_get_aux_event(), wolfsentry_event_get_label(), wolfsentry_addr_family_max_addr_bits(); final fixes and unit test coverage for wolfsentry_builtin_action_track_peer(); restore WOLFSENTRY_ACTION_RES_DEROGATORY bit to _UNREACHABLE cases in lwip/packet_filter_glue.c; make wolfsentry_table_ent_get_by_id() a public API; add wolfsentry_static_assert2() taking 2 args like old wolfsentry_static_assert(), and change the latter to build the message string using cpp stringification; remove frivolous WOLFSENTRY_ACTION_RES_STOP from assignments in load_config.c:convert_default_policy().
…UDP_JSON(): update call to wolfsentry_action_res_decode() to call by new name wolfsentry_action_res_assoc_by_flag().
JacobBarthelmeh
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From ChangeLog.md:
Routes can now be configured to match traffic with designated
action_resultsbit constraints, and can be configured to update
action_resultsbits, byinserting the route with a parent event that has the desired configuration.
Parent events can now also be configured to add or clear route flags for all
routes inserted with that parent event.
Added new
aux_eventmechanism to facilitate distinct configurations for astatic generator route and the narrower ephemeral routes dynamically created
when it is matched.
Added a new built-in action,
"%track-peer-v1", that can be used in combinationwith the above new facilities to dynamically spawn ephemeral routes, allowing
for automatic pinhole routes, automatic adversary tracking, and easy
implementation of dynamic blocks for port scanning adversaries.
For details, see rest of entry in ChangeLog.md for release 1.4.0.