Skip to content

Check whether interpreter changed and type (#123)#418

Merged
theacodes merged 1 commit intowntrblm:mainfrom
dpalmasan:interpreter-changed
Apr 24, 2021
Merged

Check whether interpreter changed and type (#123)#418
theacodes merged 1 commit intowntrblm:mainfrom
dpalmasan:interpreter-changed

Conversation

@dpalmasan
Copy link
Copy Markdown
Contributor

@dpalmasan dpalmasan commented Apr 10, 2021

This is an attempt to fix #123

The steps are the following

  • Check virtualenv interpreter
  • Check current interpreter
  • If there is a match, do nothing. If they are different, recreate
  • Check if the type of interpreter remains the same.

Not sure, but for the last case I made an assertion.

@dpalmasan dpalmasan force-pushed the interpreter-changed branch 4 times, most recently from 57e6590 to 3f94d57 Compare April 10, 2021 23:08
@dpalmasan dpalmasan force-pushed the interpreter-changed branch from 3f94d57 to d7ff39c Compare April 10, 2021 23:27
@theacodes theacodes merged commit a67c9a2 into wntrblm:main Apr 24, 2021
@theacodes
Copy link
Copy Markdown
Collaborator

theacodes commented Apr 24, 2021

Thank you!

@cjolowicz cjolowicz mentioned this pull request May 22, 2021
Closed
@cjolowicz
Copy link
Copy Markdown
Collaborator

cjolowicz commented May 22, 2021

This caused a regression, see #424.

@dpalmasan
Copy link
Copy Markdown
Contributor Author

dpalmasan commented May 22, 2021

Thanks, gonna check

@cjolowicz cjolowicz mentioned this pull request May 24, 2021
Merged
This was referenced Jun 6, 2021
Merged
Closed
@mlech-reef mlech-reef mentioned this pull request Oct 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theacodes theacodes theacodes approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

reuse_existing should check the interpreter

3 participants

@dpalmasan @theacodes @cjolowicz