Compile time lock PIN definition #4307
Conversation
|
How do I set this? I tried |
|
Either: |
| WLED_GLOBAL bool wifiLock _INIT(false); // prevents access to WiFi settings when OTA lock is enabled | ||
| WLED_GLOBAL bool aOtaEnabled _INIT(true); // ArduinoOTA allows easy updates directly from the IDE. Careful, it does not auto-disable when OTA lock is on | ||
| WLED_GLOBAL char settingsPIN[5] _INIT(""); // PIN for settings pages | ||
| WLED_GLOBAL bool otaLock _INIT(false); // prevents OTA firmware updates without password. ALWAYS enable if system exposed to any public networks |
There was a problem hiding this comment.
Revert unrelated whitespace changes please
There was a problem hiding this comment.
I want to keep comments aligned. Personal preference.
There was a problem hiding this comment.
That's fine for when making changes, not for unrelated code
It's bad practice to apply formatting changes to code not related to the PR, it creates harder to review PRs and breaks the history of each line making debugging issues harder as git blame will make it appear the code has changed more recently that it has and with incorrect description
Yes, that is expected. The code does not modify existing configuration.
Then a check where a bug is is in order. Though that may be good as it will allow to set WiFi credentials (unfortunately that will be available only once). |
|
There's one more thing that needs to be done: allow WiFi settings to be available until WiFi is configured. |
|
I would prefer that the WiFi settings be locked when I set a pin (as they are now). I think this would be the expected behavior when I set a pin. |
I specifically mentioned "configured" WiFi. Even if you run it unconnected in AP mode. |
|
Are there any objections to this PR? It is an "opt-in" feature for those that self-compile and does not affect regular official builds. |
Adds ability to define default settings PIN at compile time (instead of no PIN defined).
Requested by a friend.