Esp8266 oappend fix #4222
Merged
Esp8266 oappend fix #4222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect IRAM pointers if we can't be sure.
This is a platform feature that asks forgiveness for PROGMEM misuse: it adds a handler such that incorrectly used PROGMEM will work without crashing, just really, *really* inefficiently. Given that most of our real-world use cases for PROGMEM strings are relatively infrequent text calls, we can err on the side of developer convenience and address performance problems if and when they arise.
This was referenced Oct 24, 2024
Contributor
|
@dosipod can you test this as well? |
Contributor
|
We tested both nodemcuv2_160 and esp8266_2m_160 .In both AR worked as expected and no more error or crash . |
Member
|
Good to merge 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
oappendshim logic introduced in #4152 also has issues withSET_F(), as it casts away the helper type needed forprint()to identify PROGMEM strings. Improve the shim logic to safely handle this case in two different ways:print()to be called;Fixes #4219.