-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New implementation of the simplified UI #3511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I was under the impression that you were about to remove |
|
I wanted to get rid of the duplicate code. |
|
The solution looks interesting but I see no point in having two files to maintain (if you override one's layout). Could you not put everything into Question: Shall we introduce a new class (i.e. "nosimple") that can be used to hide (or otherwise manipulate) elements not belonging into simplified user interface? I have yet to test it but from your screenshots I cannot see simplified segments. Are they intentionally hidden? IMO if there is just one force it's opacity to 255 and state to on and you can hide it, but if there are 2 or more, display their power buttons and opacity (brightness) sliders. |
|
At first I also thought about putting everything in a file, but since there was no information in the I'm not sure whether the new class is absolutely necessary, because only display is actually set to The simplified segments are not implemented yet because I didn't quite understand what you meant, but now I do. I will add that. |
|
One more question: Could you condense palettes and effects into a searchable drop-down list? |
|
Yes, I can do that. 👍🏼 |
|
I moved everything to
Here are some screenshots of what it looks like now:
I have two questions:
I am open to suggestions for improvement and feedback. 😄 |
Nevertheless it is nice to see this progress. |
|
@WoodyLetsCode ❤️ I finally had the time to testdrive this PR. Marvelous job! Still, I'd do this (no segment names and thinner segment spacing): And I found this visual error (incorrect width of palettes): I do miss presets (at least quick loads are there) but I get there needs to be some sort of compromise. @Aircoookie and @softhack007 please review and comment. |
|
Perhaps: #segcont.simple .lstI {
margin-top: 4px;
min-height: unset;
} |
|
Thanks @blazoncek for testing! I will change the segments according to your screenshot. 👍🏼 I will also look into the visual error, I couldn't reproduce it at the moment. I thought it would be better to just have the quick load of presets, because that would lead to a minimalized and simpler UI. But if you want to have presets in the simple UI, I could add that as well. I'm currently torn between two design ideas. Which one do you prefer? Or do you have other ideas? I'm open to that as well. |
|
I prefer my solution, but I leave it to you. |
|
I'd just like to give my opinion on the design of the palette selector. I would have two alternatives suggestions
|
|
@Moustachauve that would be preferable but would also mean (I think) to make two versions of UI (as was the case with simple.htm). |
|
It could be done by switching some CSS classes in JS I believe. |
Please help. 😄 |
|
I don't know how to contribue to this PR (I couldn't push), but I made this change here to turn the palette selection into a dialog: It's an early prototype that could probably be improved. Here's what it looks like: |
Add a new remote (Woody's WLED.git) to your fork ( |
|
Thank you @Moustachauve ! ❤️ Your screenshot looks really impressive! I can't wait to get a PR from you. |
|
@WoodyLetsCode if you're not afraid you can grant @Moustachauve collaborator rights to your repo. It will be faster developing in tandem that way. You can revoke at any time. |
|
BTW I'd take the dropdown approach for both: palettes and effects. I'd leave effect sliders on screen at all times. |
|
Good idea. I have granted @Moustachauve collaborator rights. |
|
I made PR w00000dy#2 in your repo |
|
Thank you @Moustachauve ! |
|
@blazoncek Do you want to have this in |
|
0_15 |
for better mobile appearance
|
I also added the dropdown menu for effects. |
Looks good. I'd also like to see active palette and effect displayed on the buttons instead of "Change ..." |
|
One more thing. Buttons for pixel art, and custom palettes (add/delete) can be hidden too. |
|
Tested and approved. @WoodyLetsCode the scroll bar in a popup window for effects or palettes still cannot be accessed using mouse in Firefox. Scrolling with mouse wheel does work though. I have not yet tested it on mobile so it may need further tweaking. |
|
@blazoncek Can you tell me which version of Firefox you are using and which operating system you use? On my Firefox it works after my commit 930a1ae |
|
Using FF 115.5.0esr on macOS 10.14 |
|
It seems that there is a difference between Firefox for Windows and Firefox for MacOS. |
|
@blazoncek It should work on macOS now. I also made a few other small changes: |
|
@WoodyLetsCode Blur looks good on a photo! I wonder what does it look like on the default single color background? Does it have enough contrast? |
|
@Moustachauve This is how it looks like on the default single color background: I think it also looks good there. |


























This turns the original UI into a simplified UI instead of having a second simplified UI. Now in the simple ui there is so much duplicate code and I think this would be a better implementation of the simplified ui. So my idea was that when the simple ui is enabled, we fetch the default ui, hide all unnecessary ui elements and then show the ui.
This is what it looks like:
I ended up not having a button to open the palettes or effects because it just adds an unnecessary click that you have to do to change your effect or palette. In the old simplified UI, you then had to scroll as well, so it makes no difference if you always have palettes and effects visible or not.
Now, because the simplified ui takes up much less space: Should we make the simplified ui compiled in by default?