Skip to content

Conversation

@blazoncek
Copy link
Contributor

@blazoncek blazoncek commented Jun 8, 2023

Adds the following:

Copy link
Member

@Aircoookie Aircoookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge :)

NeoGammaWLEDMethod might be nice to have as an option, but right now I don't see any benefit to calling it from NPB. The current approach of pre-calculating gamma is optimal performance wise and has no drawbacks in my opinion.

@blazoncek
Copy link
Contributor Author

NeoGammaWLEDMethod might be nice to have as an option, but right now I don't see any benefit to calling it from NPB.

Indeed. That is why I only created class and added comment into bus_wrapper.h. The truth is @Makuna created similar class after I suggested it to him.
Makuna/NeoPixelBus#644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSON APIs assigned to buttons , e.g {"ps":"1~4~"} Settings page not working on reverse proxy

3 participants